https://bugzilla.redhat.com/show_bug.cgi?id=1430364 --- Comment #6 from Stephen Gallagher <sgallagh@xxxxxxxxxx> --- (In reply to Matthew Smith from comment #5) > Apologies, here is my updated (unofficial) review. > > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > Issues: > ======= > - All build dependencies are listed in BuildRequires, except for any that > are listed in the exceptions section of Packaging Guidelines. > Note: These BR are not needed: coreutils make bash > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 > https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2 says: "you should not assume any other packages are present as RPM dependencies and anything brought into the buildroot by the build system may change over time." I'm not sure which old list you were looking at, but these days it's generally considered to be better if we explicitly include anything we know that we rely upon. Redundancy is less of a problem than missing something. > ===== SHOULD items ===== > > Generic: > [x]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. > [x]: Final provides and requires are sane (see attachments). > [x]: Package functions as described. > [!]: Latest version is packaged. Well, 2.3.0 was the latest when I initially submitted this :) I'll update to 2.4.0 with my next pass. > > Rpmlint > ------- > Checking: argbash-2.3.0-0.1.fc27.noarch.rpm > argbash-2.3.0-0.1.fc27.src.rpm > argbash.noarch: W: only-non-binary-in-usr-lib > argbash.noarch: W: no-manual-page-for-binary argbash > argbash.noarch: W: no-manual-page-for-binary argbash-1to2 > argbash.noarch: W: no-manual-page-for-binary argbash-init Upstream has no manpages. > argbash.src:48: E: hardcoded-library-path in %{_prefix}/lib/argbash/ > 2 packages and 0 specfiles checked; 1 errors, 4 warnings. > Fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
