https://bugzilla.redhat.com/show_bug.cgi?id=1453084 --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok 1. sources: NOT ok $ spectool -g *.spec Getting https://releases.pagure.org/fedora-design/fedora-workstation-backgrounds-1.0.tar.gz ... curl: (22) The requested URL returned error: 404 Not Found It appears Source0 should be instead: Source0: https://releases.pagure.org/fedora-design/%{name}/%{name}-%{version}.tar.gz after fixing that, another problem, 2. unverifiable sources md5sum in src.rpm: 5312e48f37c9f7e221ee8b59f4bd5d56 fedora-workstation-backgrounds-1.0.tar.gz md5sum from downloaded source: a2b0dc0613b1090888e48eaf5c83ce5b fedora-workstation-backgrounds-1.0.tar.gz 3. licensing I'm not super familiar with CC enough to confidently determine if all the combined licenses ends up with an aggregate License: CC-BY-SA as currently specified in the .spec. I'd feel better if they were all explicitly listed to be on the safe side, so use something like: License: CC-BY-SA and CC-BY and CC0 otherwise, the form and content of the package is relatively simple and clean. Fix items 1-3, and I'll approve this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
