[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #28 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> ---
(In reply to Michael Schwendt from comment #27)
> > %posttrans
> > gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
> > desktop-file-validate %{_datadir}/applications/keepassxc.desktop &> /dev/null || :
> 
> That desktop-file-validate call isn't acceptable like that. You are supposed
> to validate .desktop files once when building the binary package. Not in
> %posttrans and then ignoring output and any errors.

Well, the spec file uses desktop-file-install in %install.
Desktop-file-validate is not necessary here at all since -file-install is
already used.

If desktop-file-validate is the only one used, then, of course, it should be in
%install.

>From the guidelines,

... one MUST run desktop-file-install (in %install) OR desktop-file-validate
(in %check or %install) ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux