https://bugzilla.redhat.com/show_bug.cgi?id=1454925 Bug ID: 1454925 Summary: Review Request: rtags - A indexer for the c language Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: ckellner@xxxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx Spec URL: hhttps://github.com/gicmo/spec/blob/master/rtags/rtags.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/gicmo/devel/fedora-26-x86_64/00555828-rtags/rtags-2.9-2.src.rpm Description: RTags is a client/server application that indexes C/C++ code and keeps a persistent file-based database of references, declarations, definitions, symbolnames etc. There’s also limited support for ObjC/ObjC++. It allows you to find symbols by name (including nested class and namespace scope). Most importantly we give you proper follow-symbol and find-references support. Fedora Account System Username: gicmo Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19707318 Two things: The project's home is on github and releases are done there (via tags), but the project also uses git submodules and these are then not included in the source tarball. I submitted a patch so we can create source tarballs via cmake that include all the sources and that went upstream and is included in the latest stable (2.9). But this means the source url in the spec file is just the filename. rpmlint warns about "missing-call-to-chdir-with-chroot", which I think gets pulled in via the general purpose rct library[1] that can perform an chroot (and then an chdir) if the program that uses the library requests it. But from a grep in the actual rtags source I dont think it is acutally used: --- 8< --- λ ~/C/p/r/rtags-2.9 → ag chroot src/rct/rct/Process.cpp 448: if (!mChRoot.isEmpty() && ::chroot(mChRoot.constData())) { 856:void Process::setChRoot(const Path &path) 859: mChRoot = path; src/rct/rct/Process.h 42: void setChRoot(const Path &path); 201: Path mCwd, mChRoot; λ ~/C/p/r/rtags-2.9 → --- >8 --- Happy for comments. ;) [1] https://github.com/Andersbakken/rct/blob/c7bd743c3ef784c27e57a710203a7321a4175078/rct/Process.cpp#L448 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
