Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sepostgresql - Security-Enhanced PostgreSQL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249522 ynakam@xxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ynakam@xxxxxxxxxxxxxx ------- Additional Comments From ynakam@xxxxxxxxxxxxxx 2007-07-30 04:16 EST ------- Hi, I am not a sponsor, but I saw you spec file. 1) >Buildrequires: checkpolicy libselinux-devel >= 2.0.13 selinux-policy-devel = 2.6.4-26.sepgsql.fc7 >Requires: policycoreutils >= 2.0.16 libselinux >= 2.0.13 selinux-policy = 2.6.4-26.sepgsql.fc7 I could not build your package. What is selinux-policy-devel = "2.6.4-26.sepgsql.fc7"? It it included in fedora? 2) You have to use more macros throughout spec file. Such as: sepostgresql -> %{name} /usr/share/selinux/devel/Makefile -> %{__datadir}/selinux/devel/Makefile and also /usr/sbin etc, you can replace them with macros. See: http://fedoraproject.org/wiki/Packaging/RPMMacros 3) Your package does not include documentation. http://fedoraproject.org/wiki/Packaging/Guidelines#head-9bbfa57478f0460c6160947a6bf795249488182b http://fedoraproject.org/wiki/Packaging/ReviewGuidelines > - MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. 4) Are you using $RPM_OPT_FLAGS/%{optflags}? http://fedoraproject.org/wiki/Packaging/Guidelines#head-8b14098227aebff1cf6188939e9d0877295ac448 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review