https://bugzilla.redhat.com/show_bug.cgi?id=1451298 Iwicki Artur <iwicki.artur@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |iwicki.artur@xxxxxxxxxx --- Comment #1 from Iwicki Artur <iwicki.artur@xxxxxxxxxx> --- I am not a packager, so this is not an official review. You should include the COPYING file in the RPM, as detailed here: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text In the %files section, the directories are unowned. You have specified file ownership, but not directory ownership. https://fedoraproject.org/wiki/Packaging:UnownedDirectories#Wildcarding_Files_inside_a_Created_Directory As a minor note, you do not need to use -n with %setup, as %{name}-%{version} is the default directory name assumed by %setup. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
