Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ustr - String library, very low memory overhead, simple to import https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248231 ------- Additional Comments From james.antill@xxxxxxxxxx 2007-07-30 03:19 EST ------- ? Perhaps it is better that all header files are hidden under /usr/include/ustr. ...if I did that the users would have to alter their -I build flags to use the headers, saying that I think I'll be forced to move at least ustr-conf.h out to /usr/lib/ and /ustr/lib64/ if multilib. development is to be supported. I'll have to think about this more. ? the fedora compilation flags (-O2) is overwritten by -O1. Is this intentional? Yes, GCC/GDB gets confused at -O2 so for a "debug mode" you want to reduce that confusion as much as possible. ? Well, it is okay, however would you rename the file which contains white space in its name? This is part of upstream, is it policy to rename upstream files? I guess I can change the spaces to dashes at install time, but it means html documentation pointing to the file won't work unless I run that through sed etc. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review