https://bugzilla.redhat.com/show_bug.cgi?id=1450679 Sandro Bonazzola <sbonazzo@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(rjones@xxxxxxxxxx | |) --- Comment #6 from Sandro Bonazzola <sbonazzo@xxxxxxxxxx> --- Thanks for the review, I'll try to address all your comments. (In reply to Richard W.M. Jones from comment #4) > Fedora-review finds the following issues: > > - Header files in -devel subpackage, if present. > Note: laby : /usr/share/laby/mods/c/lib/robot.h laby : > /usr/share/laby/mods/cpp/lib/robot.h > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages This one is intentional. The game teach you also how to program in C and in order to move the ant, you'll need the robot.h header file. It isn't the use case addressed by -devel subpackages. Should I add a comment in the spec file about this? > - Package contains BR: python2-devel or python3-devel What's BR? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
