[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #3 from Richard W.M. Jones <rjones@xxxxxxxxxx> ---
You shouldn't use any of the following:

%global opt %(test -x %{_bindir}/ocamlopt && echo 1 || echo 0)

- This has been replaced by either %ocaml_native_compiler or
  %ocaml_natdynlink.  Please see /usr/lib/rpm/macros.d/macros.ocaml-srpm

%global debug_package %{nil}

- Debuginfo should work these days.  You may need to modify the build
  so it passes -g option to ocamlopt.

%global _use_internal_dependency_generator 0
%global __find_requires /usr/lib/rpm/ocaml-find-requires.sh
%global __find_provides /usr/lib/rpm/ocaml-find-provides.sh

- This is plain wrong nowadays.  The RPM dependency generator
  just does the right thing.

And yes I'm aware that the OCaml packaging guidelines aren't up to date
on some of these issues.  Also that OCaml packages don't consistently
do this -- I've been fixing those over time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux