[Bug 1398922] Review Request: uftrace - User-space function call tracer for C and C++ programs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1398922

Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dridi.boukelmoune@xxxxxxxxx



--- Comment #17 from Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> ---
The next release should work fine with the %configure macro [1] so that should
soon not be a problem. If you think that the shared object should be in a
private directory because they're not directly linked to but rather pre-loaded
you should discuss this upstream and point them to the relevant Fedora
guidelines.

You can however do that in your spec like this:

    %configure --libdir=%{_libdir}/%{name}

Until the next release, you can patch [2,3] the configure script in your spec.

As upstream mentioned on github, I was about to recommend verbose building to

1) verify that the flags are properly passed and
2) make it easier to troubleshoot remote builds in general:

    %make_build V=1

There are other issues with the spec, have a look at the rpmlint output for
starters. I found one in the changelog that I'm sure rpmlint will report, I'll
keep the others for later.

[1] https://github.com/namhyung/uftrace/pull/98
[2] https://patch-diff.githubusercontent.com/raw/namhyung/uftrace/pull/98.patch
[3] https://patch-diff.githubusercontent.com/raw/namhyung/uftrace/pull/98.diff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux