https://bugzilla.redhat.com/show_bug.cgi?id=1450691 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Neal Gompa from comment #3) > (In reply to Fabio Valentini from comment #2) > > Package Review > > ============== > > > > [!]: Package consistently uses macros (instead of hard-coded directory > > names). > > > > Since you're defining the source project name as a global, you should > > consistently use it, too (missing on lines 41, 51). > > > > D'oh. Fixed. > > > > > [!]: Final provides and requires are sane: > > > > Provides > > -------- > > python3-pyrpmmd: > > python3-pyrpmmd > > python3.6dist(pyrpmmd) > > python3dist(pyrpmmd) > > > > python2-pyrpmmd: > > python-pyrpmmd > > python2-pyrpmmd > > python2.7dist(pyrpmmd) > > python2dist(pyrpmmd) > > > > As far as I can tell from the Packaging:Python guidelines, "python-pyrpmmd" > > should be provided by the subpackage using the current system python > > implementation (python3 on rawhide, so it should be provided by > > python3-pyrpmmd). Since the appropriate macro is used, %python_provide seems > > to be broken there. > > > > Unfortunately, this is by design. The macro has not been switched to have > python-* on Python 3 packages. That decision will come up in the coming > years... Well, then the wording of the Packaging:Python wiki page is strange if that hasn't been switched over, despite python3 being the default now. ... > > > > rpmlint issues > > -------------- > > > > Additionally, there are some pylint errors you might want to inform > > "upstream" about: > > > > python2-pyrpmmd.noarch: E: incorrect-fsf-address > > /usr/lib/python2.7/site-packages/rpmmd/Errors.py > > python2-pyrpmmd.noarch: E: incorrect-fsf-address > > /usr/lib/python2.7/site-packages/rpmmd/misc.py > > python2-pyrpmmd.noarch: E: incorrect-fsf-address > > /usr/lib/python2.7/site-packages/rpmmd/repoMDObject.py > > > > python3-pyrpmmd.noarch: E: incorrect-fsf-address > > /usr/lib/python3.6/site-packages/rpmmd/Errors.py > > python3-pyrpmmd.noarch: E: incorrect-fsf-address > > /usr/lib/python3.6/site-packages/rpmmd/misc.py > > python3-pyrpmmd.noarch: E: incorrect-fsf-address > > /usr/lib/python3.6/site-packages/rpmmd/repoMDObject.py > > Will do. :) Since you fixed the things I pointed out and those were the only issues I could find, I've approved the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
