[Bug 1450691] Review Request: python-pyrpmmd - Python module for reading rpm-md repo data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1450691



--- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
Package Review
==============

[!]: Package consistently uses macros (instead of hard-coded directory
     names).

Since you're defining the source project name as a global, you should
consistently use it, too (missing on lines 41, 51).


[!]: Final provides and requires are sane:

Provides
--------
python3-pyrpmmd:
    python3-pyrpmmd
    python3.6dist(pyrpmmd)
    python3dist(pyrpmmd)

python2-pyrpmmd:
    python-pyrpmmd
    python2-pyrpmmd
    python2.7dist(pyrpmmd)
    python2dist(pyrpmmd)

As far as I can tell from the Packaging:Python guidelines, "python-pyrpmmd"
should be provided by the subpackage using the current system python
implementation (python3 on rawhide, so it should be provided by
python3-pyrpmmd). Since the appropriate macro is used, %python_provide seems to
be broken there.


rpmlint issues
--------------

Additionally, there are some pylint errors you might want to inform "upstream"
about:

python2-pyrpmmd.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/rpmmd/Errors.py
python2-pyrpmmd.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/rpmmd/misc.py
python2-pyrpmmd.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/rpmmd/repoMDObject.py

python3-pyrpmmd.noarch: E: incorrect-fsf-address
/usr/lib/python3.6/site-packages/rpmmd/Errors.py
python3-pyrpmmd.noarch: E: incorrect-fsf-address
/usr/lib/python3.6/site-packages/rpmmd/misc.py
python3-pyrpmmd.noarch: E: incorrect-fsf-address
/usr/lib/python3.6/site-packages/rpmmd/repoMDObject.py

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux