Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nodoka-theme-gnome - The Nodoka Metacity theme and Gnome metatheme https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248516 ------- Additional Comments From mclasen@xxxxxxxxxx 2007-07-30 00:01 EST ------- rpmlint is silent on the produced rpms package name: ok, I think. spec name: ok packaging guidelines: mostly ok - might be a good idea to put a comment pointing to the wiki location of the upstream sources - should add a comment about the "inverse relationship" between main and subpackage, where the main package requires the subpackage license: ok license field: ok license file: ok spec language: ok spec legibility: ok upstream sources: ok buildable: ok excludearch: n/a build deps: ok locales: n/a shared libs: n/a relocatable: n/a directory ownership: there is a conflict where both the gtk theme package and the metacity theme package own /usr/share/themes/Nodoka. Possible solution: make the metacity theme package require the gtk theme package file list dupes: ok file permissions: ok %clean: ok macro use: ok permissible content: ok large docs: n/a %doc content: ok header files: n/a static libs: n/a pc files: n/a shared lib symlinks: n/a devel package: n/a libtool archives: n/a gui apps: n/a file ownership: see above %install: ok utf8 filenames: ok -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review