https://bugzilla.redhat.com/show_bug.cgi?id=1372866 --- Comment #33 from Jason Taylor <jtfas90@xxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #32) > You should provide a symlink to the spec file and srpm file directly in > comments, so that fedora-review can find them: > spec file: https://jtaylor.fedorapeople.org/hyperscan/hyperscan.spec > srpm: > https://jtaylor.fedorapeople.org/hyperscan/hyperscan-4.4.1-1.fc27.src.rpm srpm: https://jtaylor.fedorapeople.org/hyperscan/hyperscan-4.4.1-2.fc27.src.rpm spec file: https://jtaylor.fedorapeople.org/hyperscan/hyperscan.spec latest scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19507079 > > https://github.com/01org/%{name}/archive/%{gittag0}.tar.gz#/%{gittag0}.tar.gz > This isn't useful — you are renaming the tarball to the original (bad) name. > You want ...#/hyperscan-%{gittag0}.tar.gz Updated > > Patch0: path.patch > A more descriptive patch name would be nice. Updated to be more descriptive > > make %{?_smp_mflags} > %make_build Updated > > make install DESTDIR=%{buildroot} > %make_install Updated > hyperscan.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: > line 4) Fixed > In the build I see various -m64 -mtune=generic, -march=core2, > -march=core-avx2, etc. It seems that it's compiling the code in different > variants, which is OK. I believe the various -march specifications are due to the "fat runtime" functionality introduced in version 4.4.0. https://github.com/01org/hyperscan/releases > The cflags specified by the .pc file are dubious: they add > -I/usr/include/hs, even though it would be better no to do that, and require > users of the library to use #include <hs/hs.h>. But that's an upstream issue > / inelegance. > > Package looks OK. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
