Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-File-chmod - perl module implementing symbolic and ls chmod modes https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249996 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-07-29 14:07 EST ------- Looks clean and builds fine; there's not much to say. The description is a bit thin but I don't think it's a blocker. * source files match upstream: ec54997c4274ca27e8e8d25585223569b15b16ed2bfdf5d0507c57787d6d05a9 File-chmod-0.32.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(File::chmod) = 0.32 perl-File-chmod = 0.32-1.fc8 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Exporter) perl(strict) perl(vars) * %check is present and all tests pass: ok 1 original state of chmod.pm: 00644 calling: chmod('+x', 'chmod.pm')... chmod.pm: 00755 calling: chmod('-x', 'chmod.pm')... chmod.pm: 00644 * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review