https://bugzilla.redhat.com/show_bug.cgi?id=1449882 --- Comment #4 from Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> --- (In reply to Athos Ribeiro from comment #2) > You might want to have a python 2 subpackage (even if upstream still does > not support python 3) and use the python_provide macro [1]. This will > probably save someone (probably you) some time in the future, when python 3 > becomes the default or when upstream starts supporting python 3 as well. Done. > Upstream provides a test suite, is there any reason for not running it in > %check? Any suggestion how to properly write %check? Writing the line "%{_python2} setup.py tests/lcms2_testsuite.py" or "%{_python2} tests/lcms2_testsuite.py" failed as a result ==================================== ERRORS ==================================== __________________ ERROR collecting tests/lcms2_testsuite.py ___________________ tests/lcms2_testsuite.py:18: in <module> import lcms2 E ImportError: No module named lcms2 =========================== 1 error in 0.04 seconds ============================ > Defining sum is not needed. You could use the %{summary} macro instead if > the summary was needed somewhere else. > Fixed. (In reply to Charalampos Stratakis from comment #3) > Also it would be good to use the %py2_build and %py2_install macros instead > of %py_build and %py_install (see [0]) as in the future, when python3 will > be the default python, these macros will be changed to reflect that. > Fixed. Here is the updated specs Spec URL: https://luya.fedorapeople.org/packages/SPECS/python-lcms2.spec SRPM URL: https://luya.fedorapeople.org/packages/SRPMS/python-lcms2-0.1-2.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
