https://bugzilla.redhat.com/show_bug.cgi?id=1441828 --- Comment #33 from mgansser@xxxxxxxx <mgansser@xxxxxxxxx> --- (In reply to Vít Ondruch from comment #30) > > > * Bundled engine.io library? > > > - It seems engine.io library is bundled by nuvolaplayer. Is it required for > > > something? If yes, shouldn't it be extracted or at least there should be > > > the "bundled()" provider [4]. > > > > > > > Engine.io is not a bundled library in the meaning as a copy of an > > independent library. It just hasn't been separated into and independent > > library yet. Engineio is used in some experimental features which are not > > built by default yet but that may change in the future. > > Frankly, I am not very satisfied with upstream response, since this [2] > commit clearly links engine.io.js file from different upstream repository. > Moreover, the .js file is in two copies currently in the source code ... > answer from upstream: I see. I thought you talked about libengineio-soup - the Vala port of engineio. It didn't occur to me there is also engine.io.js. That could be unbundled. However, I have no idea what is the typical filesystem location for JavaScript libraries. Let's continue at #341. Ticket: https://github.com/tiliado/nuvolaplayer/issues/341 > ~~~ > nuvolaplayer.x86_64: W: shared-lib-calls-exit > /usr/lib64/libnuvolaplayer3-runner.so exit@GLIBC_2.2.5 > This library package calls exit() or _exit(), probably in a non-fork() > context. Doing so from a library is strongly discouraged - when a library > function calls exit(), it prevents the calling program from handling the > error, reporting it to the user, closing files properly, and cleaning up any > state that the program has. It is preferred for the library to return an > actual error code and let the calling program decide how to handle the > situation. > ~~~ > > - But this one ^^ seems to be interesting. Not sure, probably good to ask > upstream about it. > answer from upstream: libnuvolaplayer3-runner.so contains the main application logic, so it ok to call exit(). Anyway, it does so only as a last resort when WebKitWebProcess hangs. Ticket: https://github.com/tiliado/nuvolaplayer/issues/340 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
