https://bugzilla.redhat.com/show_bug.cgi?id=1432983 --- Comment #5 from Lubomir Rintel <lrintel@xxxxxxxxxx> --- Rest of the review: * Package named correctly * Packaging the latest version * License good for Fedora (see below for remarks about the license tag) * License text included * Filelist sane * Requires/Provides sane * Scriptlets look good 6.) Please unbundle cairo, GLEW and perhaps dxflib (ideally ask upstream to allow building against system copies). See the wiki reference above for explanation why bundling is bad. 7.) Use the correct compiler flags. E.g. change scons ccflags="%{?fedora:-I%{_includedir}/v8-3.14/}" to scons ccflags="%{?fedora:-I%{_includedir}/v8-3.14/} %{optflags}" wherever appropriate. 8.) The license tag is incorrect: License: LGPLv2 It looks like the camotics source is GPLv2+. (Some of the bundled files use different licenses -- if it's not possible to unbundle them then they should be included in the License tag). 9.) rpmlint is unhappy camotics.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/camotics/examples/tiger/tiger.nc camotics.x86_64: W: spurious-executable-perm /usr/share/doc/camotics/examples/camotics/camotics.svg camotics.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/camotics/examples/cameo/cameo.nc camotics.x86_64: E: script-without-shebang /usr/share/camotics/tpl_lib/clipper/clipper.js camotics.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/camotics/examples/stl-test/V1.stl Please at least remove the executable bits; ideally also recode the DOS line endings in examples. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
