Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glglobe - OpenGl Globe - Earth simulation https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249992 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |177841 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-07-29 02:05 EST ------- I did not investigate how this package builds, so at this point I can't tell you how to pass the proper compiler flags to it. I don't see any configure script in the package, so I'm not sure what good a call to %configure could possibly do. If there's just a plain Makefile, you probably just need check that it will allow you to pass CFLAGS on the make line, or patch it to allow that. > Is it because the macros expanded out are multi-line, and perhaps even start > with a new line that the expanded part does not stay commented ? Perhaps; I'm not intimately familiar with the details of how RPM expands macros. > ps. This is my first package up for review, and I'll eventually need a > sponsor. This should block FE-NEEDSPONSOR, then. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review