https://bugzilla.redhat.com/show_bug.cgi?id=1448298 --- Comment #2 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- Thank you! (In reply to František Dvořák from comment #1) > Nice packaging. > > * I guess the Rakefile modification is not strictly needed, but it is there > as prevention, because pkgconfig is not used? This is because unless modifying Rakefile, pkgconfig(webkit2gtk-4.0) (i.e. webkitgtk4-devel) will be needed as BR, while actually webkitgtk4 is needed as BR (and Requires) (and -devel is not needed). > * Not using BR pkgconfig(webkit2gtk-4.0) is good idea, development > dependency of webkitgtk4 is not needed here. > > * run-test.rb probably doesn't need to load modules (only the code at the > end is needed). But it is actually good to perform only minimal changes as > used here. Note that "-extension RANDR" means _not_ loading RANDR, there was a bug that loading RANDR extension on Xvfb make it crash (current default is loading also RANDR extension), but I guess this bug is already fixed, will remove. > * Usage of Obsoletes is well commented. > > > Package APPROVED! Thank you. I will surely review your package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
