https://bugzilla.redhat.com/show_bug.cgi?id=1444634 Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #4 from Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> --- (In reply to Simone Caronni from comment #3) > (In reply to Luya Tshimbalanga from comment #2) > > - All build dependencies are listed in BuildRequires, except for any that > > are listed in the exceptions section of Packaging Guidelines. > > Note: These BR are not needed: make > > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 > > Fixed. Checked. > > - Large documentation must go in a -doc subpackage. Large could be size > > (~1MB) or number of files. > > Note: Documentation size is 67993600 bytes in 2648 files. > > See: > > http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation > > > [!]: Large data in /usr/share should live in a noarch subpackage if package > > is arched. > > Note: Arch-ed rpms have a total of 68751360 bytes in /usr/share > > openvdb-devel-4.0.1-1.fc27.x86_64.rpm:68628480 > > Moved to noarch doc subpackage. \Checked. > > [!]: Uses parallel make %{?_smp_mflags} macro. > > It's already done with %make_build: > > > openvdb.x86_64: W: hidden-file-or-dir /usr/lib/.build-id > > openvdb.x86_64: W: hidden-file-or-dir /usr/lib/.build-id > > This actually was an issue with an interim Fedora update, it has disappeared. That was an odd one and good to hear it is now resolved. > > openvdb-libs.x86_64: W: unused-direct-shlib-dependency > > /usr/lib64/libopenvdb.so.4.0.1 /lib64/libboost_thread.so.1.63.0 > > Fixed. Checked > > openvdb-libs.x86_64: W: file-not-utf8 /usr/share/doc/openvdb-libs/CHANGES > > Fixed. Checked After verification, the packege is approved for the repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
