https://bugzilla.redhat.com/show_bug.cgi?id=1441828 --- Comment #26 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to mgansser@xxxxxxxx from comment #24) > (In reply to Vít Ondruch from comment #23) > > (In reply to mgansser@xxxxxxxx from comment #22) > > Well, the tests were not modified in past 3 years, so they might not be in > > good shape ... dunno :/ > > I think we should not use the test. At minimum, it would be good to document it somehow in the .spec file. And it would be even better to poke upstream about that ... (In reply to mgansser@xxxxxxxx from comment #25) > (In reply to Vít Ondruch from comment #21) > > > > * Bundled engine.io library? > > - It seems engine.io library is bundled by nuvolaplayer. Is it required for > > something? If yes, shouldn't it be extracted or at least there should be > > the "bundled()" provider [4]. > > > > Engine.io is not a bundled library in the meaning as a copy of an > independent library. It just hasn't been separated into and independent > library yet. Engineio is used in some experimental features which are not > built by default yet but that may change in the future. Then I would suggest to not ship the library ATM if possible ... > > * What is the purpose of %{_datadir}/nuvolaplayer3/web_apps/test > > - Is the content of the directory used somewhere? > > > > This is a test service to test various features of Nuvola (nuvola -D -a > test). It may be helpful when you need provide your users with support. It > might go to devel subpackage though. Good advice. > > * What is the purpose of %{_datadir}/nuvolaplayer3/audio > > - Is the .mp3 fie used somewhere for something? > > > > The mp3 file is used to check that gstreamer can play mp3 files. How to do that? Is this available somewhere in UI? Is this available somewhere to end user? I'd suggest to not ship the file unless it proves we are missing it for something ... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
