https://bugzilla.redhat.com/show_bug.cgi?id=1445366 --- Comment #6 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Everytime package spec is modified/updated its good to increase the release number and add appropriate changelog entry. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: 1) The only remaining issue now is that after installing this updated package, no package owns directory /usr/share/unicode/emoji. To fix this add following to %files as well %dir %{emojidir} 2) Shouldn't license be "Unicode"? Please check this https://fedoraproject.org/wiki/Licensing/Unicode ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/unicode/emoji [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/unicode/emoji [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/unicode(unicode- ucd, cldr-emoji-annotation) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: unicode-emoji-4.0-1.fc27.noarch.rpm unicode-emoji-4.0-1.fc27.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- unicode-emoji (rpmlib, GLIBC filtered): Provides -------- unicode-emoji: unicode-emoji Source checksums ---------------- http://www.unicode.org/Public/emoji/4.0/emoji-data.txt : CHECKSUM(SHA256) this package : 11e04eabc3cbda7c9337f6cced9ebe331673d776d20558697dbad9221d4084ac CHECKSUM(SHA256) upstream package : 11e04eabc3cbda7c9337f6cced9ebe331673d776d20558697dbad9221d4084ac http://www.unicode.org/Public/emoji/4.0/emoji-sequences.txt : CHECKSUM(SHA256) this package : 369961fc8ff454d47ca0541124c7c9f5d83436e76f2641935b203427c67c5d2b CHECKSUM(SHA256) upstream package : 369961fc8ff454d47ca0541124c7c9f5d83436e76f2641935b203427c67c5d2b http://www.unicode.org/copyright.html : CHECKSUM(SHA256) this package : 6e1ac9056574635b40b6d198f09ec063e4cece2c7295593f10194cac9b23f8a5 CHECKSUM(SHA256) upstream package : 6e1ac9056574635b40b6d198f09ec063e4cece2c7295593f10194cac9b23f8a5 http://www.unicode.org/Public/emoji/4.0/ReadMe.txt : CHECKSUM(SHA256) this package : f49a0fb20129b345fc8bc320393a1a854a63e359bf05cf18eefb3c6ffc4196c1 CHECKSUM(SHA256) upstream package : f49a0fb20129b345fc8bc320393a1a854a63e359bf05cf18eefb3c6ffc4196c1 http://www.unicode.org/Public/emoji/4.0/emoji-test.txt : CHECKSUM(SHA256) this package : ceafd77cc07eca1a2ebafebd9c7d6d63c6dd3808243365dd14eb500d39f31769 CHECKSUM(SHA256) upstream package : ceafd77cc07eca1a2ebafebd9c7d6d63c6dd3808243365dd14eb500d39f31769 http://www.unicode.org/Public/emoji/4.0/emoji-zwj-sequences.txt : CHECKSUM(SHA256) this package : 254b25ca1953a0aba72dff04d15176ac3abe5e6a2022546edaa13d74a96406ee CHECKSUM(SHA256) upstream package : 254b25ca1953a0aba72dff04d15176ac3abe5e6a2022546edaa13d74a96406ee Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1445366 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
