https://bugzilla.redhat.com/show_bug.cgi?id=1439894 Zdenek Dohnal <zdohnal@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |skozina@xxxxxxxxxx Flags| |needinfo?(skozina@xxxxxxxxx | |m) --- Comment #4 from Zdenek Dohnal <zdohnal@xxxxxxxxxx> --- Hi, sorry for delay, there is my review - there is some issues, but most "MUST" are ok. So it will need some more work. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - move scripts from %{python_sitelib} to /usr/share/ddiskit - create man page - binary should have man page - mark ddiskit.bash as config with %config(noreplace) - if you have new directories in %files section, you need to define it before using with %dir - f.e. %dir %{datadir}/%{srcname} - where you are using "ddiskit" in spec, you can use %{srcname} - it is more general solution - dependency on kernel-devel - is it necessary? - empty files 'default' and 'rh-release' in 'profiles' directory - delete them or add into them some comments like "This file is for..." - no need for %{srcname} global macro - you should use %{name} macro ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3)", "Unknown or generated". 11 files have unknown license. Detailed output of licensecheck in /home/zdohnal/repo_upstream/ddiskit/review-ddiskit/licensecheck.txt [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/ddiskit/templates, /usr/share/ddiskit, /usr/share/ddiskit/profiles - if you have new directories in %files section, you need to define it before using with %dir - f.e. %dir %{datadir}/%{srcname} [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/ddiskit/profiles, /usr/share/ddiskit/templates, /usr/share/ddiskit - same as previous [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). - you can use %{name} macro in spec [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. - dependency on kernel-devel? [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [!]: Package complies to the Packaging Guidelines - it doesn't comply in issues mentioned before [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x ]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). - kernel-devel requirement [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ddiskit-3.3-1.fc27.noarch.rpm ddiskit-3.3-1.fc27.src.rpm ddiskit.noarch: E: devel-dependency kernel-devel ddiskit.noarch: W: non-conffile-in-etc /etc/bash_completion.d/ddiskit.bash ddiskit.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ddiskit/__init__.py 644 /usr/bin/python ddiskit.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ddiskit/ddiskit.py 644 /usr/bin/python ddiskit.noarch: E: zero-length /usr/share/ddiskit/profiles/default ddiskit.noarch: E: zero-length /usr/share/ddiskit/profiles/rh-release ddiskit.noarch: W: no-manual-page-for-binary ddiskit 2 packages and 0 specfiles checked; 5 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- ddiskit.noarch: E: devel-dependency kernel-devel ddiskit.noarch: W: non-conffile-in-etc /etc/bash_completion.d/ddiskit.bash ddiskit.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ddiskit/__init__.py 644 /usr/bin/python ddiskit.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ddiskit/ddiskit.py 644 /usr/bin/python ddiskit.noarch: E: zero-length /usr/share/ddiskit/profiles/default ddiskit.noarch: E: zero-length /usr/share/ddiskit/profiles/rh-release ddiskit.noarch: W: no-manual-page-for-binary ddiskit 1 packages and 0 specfiles checked; 5 errors, 2 warnings. Requires -------- ddiskit (rpmlib, GLIBC filtered): /usr/bin/python createrepo genisoimage kernel-devel kmod python(abi) redhat-rpm-config Provides -------- ddiskit: ddiskit python2.7dist(ddiskit) python2dist(ddiskit) Source checksums ---------------- https://github.com/orosp/ddiskit/archive/3.3.tar.gz : CHECKSUM(SHA256) this package : 8d0fb8fb2798c56dc01a7aa589da63cfa822bc830f55b7b8405eb3fcc1df5154 CHECKSUM(SHA256) upstream package : 8d0fb8fb2798c56dc01a7aa589da63cfa822bc830f55b7b8405eb3fcc1df5154 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -n ddiskit -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
