[Bug 1245962] Review Request: golang-github-petar-GoLLRB - Left-Leaning Red-Black implementation of balanced binary search trees

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1245962



--- Comment #7 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> ---
> If it goes under %doc, it will get installed out of $GOPATH/src directory
> and becomes uncompileable. The usual use case is to run `go build
> github.com/petar/GoLLRB/blob/master/example'.
> 

One could build it in his home directory, right? It just feels odd to include
those examples in the package not as documentation as other non golang packages
do. We should compromise to a pattern though (if they are to be packaged in the
gopath, maybe this should be pointed in the guidelines).

> The YYYYMMDD date is impossible to detect without touching the corresponding
> git repository. It requires cloning a repository locally, checking the
> commit and accessing its commit date.
> 
> Additional, the guidelines are not clear what date to use. Date of the
> snapshot a.k.a commit date? rpmbuild date? Or any date?

The rpmbuild date seems to be enough [1]

[1]:
< tibbs> The idea is to communicate how old the snapshot is.
< athos> so using the date the packager took the snapshot would be ok, right
(although it may be ambiguous as ajax pointed out)?
< tibbs> Yes, that's fine.  It would only matter if you were specifically
taking a snapshot of a commit that is older than what's currently at the head.
< tibbs> The whole point, though, is to give humans a relatively easy way to
judge that something is "out of date".
< tibbs> Including a commit hash doesn't do that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux