Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtkperf - Test GTK+ performance https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248778 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-07-28 10:45 EST ------- Some comments (just watched your spec file and tried to rebuild) * For sourceforge source, please refert to the section "Sourceforge.net" of http://fedoraproject.org/wiki/Packaging/SourceURL * Please follow the fedora usage of build root (section: "BuildRoot tag" of http://fedoraproject.org/wiki/Packaging/Guidelines ) * export CFLAGS="%{optflags}" This is not needed as %configure sets it (please check what %configure actually does by "rpm --eval %configure") * Please set vendor id for desktop file (the section "desktop-file-install usage" of http://fedoraproject.org/wiki/Packaging/Guidelines ) * We now recommend %defattr(-,root,root,-) * rebuild failed. At least desktop-file-utils is missing from BuildRequires. http://koji.fedoraproject.org/koji/taskinfo?taskID=80492 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review