[Bug 1446927] Review Request: rubygem-native-package-installer - Native packages installation helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1446927

František Dvořák <valtri@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from František Dvořák <valtri@xxxxxxxxxx> ---
Some cosmetics/questions:

* Package contains BuildRequires: ruby(release)

It is probably not needed? But it's OK - guidelines doesn't mention nor
discourage it and it is generated by gem2rpm.

* New version 1.0.1 has been released right now

* Function is OK

ruby -rnative-package-installer -e 'p
NativePackageInstaller::ExecutableFinder::new("service").find'

Package APPROVED!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux