[Bug 1444766] Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1444766



--- Comment #3 from Tom Hughes <tom@xxxxxxxxxx> ---
The tests are really enabled so setting enable_tests is a bit misleading - the
real test can be run with "mocha test.js" and do pass but they require assume
which isn't packaged.

I suggest adding the code to tun the real tests but disabled and with a comment
explaining why, then make the basic load test run when tests are disabled.

Also there's an rpmlint waring about mixed spaces and tabs and test.js is
getting included in the built package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux