Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bouml - UML2 tool box to specify and generate code https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247417 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.w.r.degoede@xxxxxx ------- Additional Comments From j.w.r.degoede@xxxxxx 2007-07-28 05:15 EST ------- Hi, I see that you already have a reviewer, so your request for one to the mailinglist is a bit strange. I know Mamoru as a good and quick reviewer, I guess he is just waiting for you to fix the libdir and cflag issues. Anyways now I'm here I've taken a quick look, so here are some things to work on for starters. Mamoru, I assume you will still do the full review once these are addressed? Must FIX ---------- * use %{_libdir} for arch specific files, you can do this by invoking make as follows in %build: make %{?_smp_mflags} BOUML_LIB=%{_libdir}/%{name} and like this in %install: make install DESTDIR=$RPM_BUILD_ROOT BOUML_LIB=%{_libdir}/%{name} * the .desktop files do not contain mimetypes, so there is no reason to run update-desktop-database in %post[un] * the %post[un] icon-cache scriptlets are wrong, the touch line misses || : and the gtk-update-icon-cache line must only be executed if gtk-update-icon-cache is present, see: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda * Add: "Requires: hicolor-icon-theme" for /usr/share/icons/hicolor/*/* dirs ownership Should FIX ---------- The CFLAGS are not really an issue as bouml uses qmake to generate the makefile and qmake puts the right flags into the generated makefiles itself. However to be _really_ sure the right flags get used, for example when RPM_OPT_FLAGS get changed (qmake uses RPM_OPT_FLAGS as defined when it was build), use the following in %build: make %{?_smp_mflags} BOUML_LIB=%{_libdir}/%{name} CFLAGS="$RPM_OPT_FLAGS" \ CXXFLAGS="$RPM_OPT_FLAGS" -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review