https://bugzilla.redhat.com/show_bug.cgi?id=1377227 --- Comment #1 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> --- Hello, I am taking this one. - As pointed in [1], packages licensed under ASL2.0 must include the license text. Note that the provided LICENSE.md file does not include the ASL2.0 text license, but a link to it. - Upstream does provide version tags [2]. - If you are packaging a post release snapshot, there are new guidelines for the Release: tag. For instance, the date the snapshot was taken must be present (this should be updated in gofed). See [3] and [4] for reference. - The conditionals on lines 52 and 69 could be removed, since they are not used at all. [1] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text [2] https://github.com/go-stack/stack/tree/v1.5.2 [3] https://fedoraproject.org/wiki/Packaging:Versioning [4] https://fedoraproject.org/wiki/Package_Versioning_Examples -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
