https://bugzilla.redhat.com/show_bug.cgi?id=1376660 --- Comment #1 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> --- Hello, I am taking this one. - Is there any reason for not running the test suite? - Upstream does have a version 0.0.1 (see [1]). So maybe you want to package a post release(?) - If you are packaging a snapshot, - check the new guidelines for the Release: tag. The date the snapshot was taken must be present (this should be updated in gofed). See [2] and [3] for reference. - The conditionals on lines 52 and 68 could be removed, since they are not used at all. [1] https://github.com/franela/goblin/tree/0.0.1 [2] https://fedoraproject.org/wiki/Packaging:Versioning [3] https://fedoraproject.org/wiki/Package_Versioning_Examples -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
