[Bug 1442576] Review Request: golang-github-restic-chunker - Implementation of Content Defined Chunking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1442576

Athos Ribeiro <athoscribeiro@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |athoscribeiro@xxxxxxxxx
             Blocks|                            |177841 (FE-NEEDSPONSOR)



--- Comment #2 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> ---
Hello Philipp,

I checked your FAS name [1] and as I see, you are not approved in the packager
group yet. I suggest you read [2] if you did not do so yet. I am blocking
FE-NEEDSPONSOR with this bug.

About your package:

- You should not generate an "empty" golang-github-restic-chunker with just a
license file and a readme file. It's ok to generate just the -devel and the
-unit-test subpackages if this package is a dependency for something else you
want to package in Fedora. Note that if it is not a dependency for something,
there is no point in packaging it: we recommend using 'go get' for development.

- There is no need for the content in the %%build section since there is no
binary files associated with this package.

- You did disabled the builds of the devel and of the unit-tests subpackages,
it means that this package generates a single binary package, with a README
file and a LICENSE file. I do not believe that is useful at all. I guess you
wanted to package, at least, the devel subpackage.

[1]
> User: philphil
> Approved Groups: cla_done cla_fpca

[2] https://fedoraproject.org/wiki/Join_the_package_collection_maintainers


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux