[Bug 1441046] Review Request: swatchbooker - Color swatch editor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1441046



--- Comment #5 from Simone Caronni <negativo17@xxxxxxxxx> ---
> [!]: Package requires other packages for directories it uses.
>      Note: No known owner of /usr/lib/swatchbooker
> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/lib/swatchbooker

> swatchbooker.src:90: E: hardcoded-library-path in %{_prefix}/lib/%{name}/*

The Python resource files should not be in /usr/lib/swatchbooker, but in
/usr/share/swatchbooker.

So, for the first error you could use the following in the %files section:

%dir %{_prefix}/lib/%{name}
%{_prefix}/lib/%{name}/*.py*

or

%{_prefix}/lib/%{name}

But you need to make sure that the python files are placed in
/usr/share/swatchbooker and that the %files section just selects that:

%{_datadir}/%{name}

> swatchbooker.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/swatchbook/codecs/ral_bcs.py /usr/bin/env python

Please fix. You can find an example here:

http://pkgs.fedoraproject.org/cgit/rpms/python-rfc3987.git/tree/python-rfc3987.spec#n55

> %global	commit c5c8b021c8f9420c26c11372c95a4a6f440dcc97
> %global	shortcommit %(c=%{commit}; echo ${c:0:7})
> %global	date 20170131
> Release:	0.1%{?date:.%{date}git}%{?dist}

This does not express the short git commit in the release field:

https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots

Please also use commit0/shortcommit0. For example:

%global    commit0 c5c8b021c8f9420c26c11372c95a4a6f440dcc97
%global    shortcommit0 %(c=%{commit0}; echo ${c:0:7})
%global    date 20170131
Release: 0.1%{?shortcommit0:.%{date}git%{shortcommit0}}%{?dist}

You can also check with %{?date} though, like you did.

Optional:

1) Sort BuildRequires, one per line


2) Have you considered building for both Python 2 and 3 in the same SPEC file
if supported by upstream?

You can still find an example in the same SPEC file above and in the packaging
guidelines URL:

http://pkgs.fedoraproject.org/cgit/rpms/python-rfc3987.git/tree/python-rfc3987.spec
https://fedoraproject.org/wiki/Packaging:Python

If you don't, please consider using unversioned python macros, so if the
default python interpreter changes the spec files remain valid.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux