[Bug 1445506] Review Request: python-fedmsg-rabbitmq-serializer - fedmsg consumer to serialize bus messages into a rabbitmq worker queue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1445506



--- Comment #1 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> ---
Hello Adam,

I am taking this review.

- The package files (consumer.py and __init__.py) were not packaged at all

- Upstream setup.py version reads 0.0.1 while package version tag reads 0.0.2

- The description for the python2- subpackage reads "An python module which
provides a convenient example.
", which is probably from an example spec file

- rpmlint throws several warnings about macros in comments. it would be nice to
append a '%' before each macro to avoid those warnings (since they are one line
macros, they should not be a problem). It also complains about a not
capitalized Summary

- It would be nice to have the python2- subpackage Requires: under the python2
subpackage itself, since your specfile is ready for a python3- subpackage

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux