[Bug 1444618] Review Request: buildah - A command line tool to facilitate working with containers and using them to build images.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1444618



--- Comment #6 from Lokesh Mandvekar <lsm5@xxxxxxxxxx> ---
C/C++:
[-]: Package does not contain kernel modules.
[-]: Package contains no static executables.



Generic:
[-]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/bash-completion,
     /usr/share/bash-completion/completions

Dan, could you add /usr/share/bash-completion to %files?


[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/.build-id(nss-pem,
     libuser, vim-common, oci-systemd-hook, python3-hawkey, dhcp-libs,
     openssh-clients, iproute, nss-tools, gc, libgpg-error,
     policycoreutils-python-utils, gdbm, gpgme, python3-cryptography, rpm-
     plugin-selinux, libsolv, gdb-headless, krb5-workstation, perl-libs,
     gmp, policycoreutils, python3-gpg, iproute-tc, kpartx, libselinux-
     python3, gnutls, pcre2, python3, cyrus-sasl-lib, hardlink, nspr, rpm-
     build, dbus, fuse-libs, polkit-libs, krb5-libs, runc, rpm-build-libs,
     libnghttp2, device-mapper-persistent-data, pkgconf, shared-mime-info,
     rpm-plugin-systemd-inhibit, pcre-cpp, rhash, audit-libs, nss-sysinit,
     libgcc, libxslt, cryptsetup-libs, perl-threads-shared, gettext-libs,
     libpkgconf, golang-github-cpuguy83-go-md2man, keyutils-libs, perl-
     Encode, python2-cryptography, sqlite-libs, btrfs-progs, system-python,
     bind99-libs, dbus-libs, nss-softokn, audit-libs-python3, GeoIP, git,
     bash, vim-enhanced, polkit, openssh, libselinux-utils, libkadm5, perl-
     Unicode-UTF8, python2-rpm, docker-v1.10-migrator, system-python-libs,
     glib2, binutils, rkt, docker-rhel-push-plugin, libstdc++, file-libs,
     gnupg2-smime, gettext-devel, nss, rpm, pcre, vim-minimal, syslinux,
     gnupg2, perl-IO, gpgme-devel, dracut, git-core, python3-cffi,
     libcroco, python3-psutil, openssh-server, ocid, libdnf, perl-version,
     drpm, info, glib2-devel, pcre-utf16, nss-util, libsemanage,
     libselinux, libtomcrypt, docker-unit-test, sqlite, sudo, golang, dhcp-
     client, file, curl, libarchive, gcc, chkconfig, cmake, libcurl,
     libsemanage-python3, gettext, coreutils, pam, nss-softokn-freebl,
     libgomp, python2-cffi, libidn2, openldap, perl-Net-SSLeay, libtool-
     ltdl, audit, rpm-libs, pcre-utf32, chrony, python3-rpm, docker),
     /usr/lib/.build-id/73(coreutils, gettext)

- Not quite sure why the /usr/lib/.build-id gets generated. rpmbuild doesn't
complain but fedora-review gives me this:

$ cat files.dir 
buildah
=======
/usr/lib/.build-id
/usr/lib/.build-id/73
/usr/share/doc/buildah
/usr/share/licenses/buildah

/usr/bin/buildah
/usr/lib/.build-id/73/4dd08b2524e8a7c20ef92dce19dee0e93bccc8
/usr/share/bash-completion/completions/buildah
/usr/share/doc/buildah/README.md
/usr/share/licenses/buildah/LICENSE
/usr/share/man/man1/buildah-add.1.gz
/usr/share/man/man1/buildah-bud.1.gz
/usr/share/man/man1/buildah-commit.1.gz
/usr/share/man/man1/buildah-config.1.gz
/usr/share/man/man1/buildah-containers.1.gz
/usr/share/man/man1/buildah-copy.1.gz
/usr/share/man/man1/buildah-from.1.gz
/usr/share/man/man1/buildah-images.1.gz
/usr/share/man/man1/buildah-mount.1.gz
/usr/share/man/man1/buildah-rm.1.gz
/usr/share/man/man1/buildah-rmi.1.gz
/usr/share/man/man1/buildah-run.1.gz
/usr/share/man/man1/buildah-umount.1.gz
/usr/share/man/man1/buildah.1.gz


[x]: Package contains no bundled libraries without FPC exception.

- github.com/docker/docker is vendored so it's ok to build this with bundled
libraries.


[-]: Development files must be in a -devel package


[!]: Useful -debuginfo package or justification otherwise.

with_debug on line 3 should be set to 1 and rebuilt so we can have a debuginfo
package, unless we need to skip debuginfo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux