[Bug 1441588] Review Request: copr-builder - build package from copr dist-git

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1441588



--- Comment #3 from Pavel Raiskup <praiskup@xxxxxxxxxx> ---
Spec URL:
https://pagure.io/copr/copr/raw/bf1d7b1f3c61b5f2ca6573d8f4bb09b8478fc32f/f/builder/copr-builder.spec
SRPM URL: http://praiskup.fedorapeople.org/copr-builder-0-13.fc25.src.rpm

Thanks for the review.

(In reply to Miroslav Suchý from comment #2)
> You are using /var/lib/copr-builder/{pid,results,live-log}. You should
> own that directories.  And lock file as %ghost.

This is the only thing I'm not sure about, the ownership of the files is
not defined "in advance" (basically any user can create files under
/var/lib/copr-builder, if in 'mock' group); so I had to use %verify
macro && and thus %ghost doesn't give us a lot of added value.  Also, other
files under /var/lib/copr-builder are automatically created, without
pre-defined filenames.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux