[Bug 1445411] Review Request: python-cysignals - Interrupt and signal handling for Cython

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1445411



--- Comment #5 from Jerry James <loganjerry@xxxxxxxxx> ---
(In reply to Paulo Andrade from comment #4)
>   I did not create a -devel at first subpackage because it is not the
> only python package installing private headers:

That makes sense for packages like python2-cffi and python2-Cython, which use
those header files for normal functioning.  Some of those seem like bugs to me,
though.  For this package, in particular, the header files won't be needed at
runtime, just the shared object, so I believe a -devel subpackage is needed. 
We can ask about this on -devel-list if you want.

>   At first, and because only sagemath uses it, I would prefer to avoid
> conflicts using a version not matching the one required by the sagemath
> package.

Sure, that's fine.

>   I did not find any match for ' \t' or '\t '. But there are lines starting
> with less than 8 spaces. That may depend on having tabs set to 4 or 8
> spaces...

I'm looking at the spec file in Emacs.  Typing 'C-s C-q TAB' shows that there
are tabs on almost all of the header lines, but "BuildRequires: python2-devel",
"BuildRequires: python3-devel", and "BuildRequires: python-sphinx" all have
spaces instead, as well as the "Summary" line for the -doc subpackage.

One other question: do the Popen() invocation changes made in the %check script
need to be made in the actual installed files, too?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux