[Bug 1441588] Review Request: copr-builder - build package from copr dist-git

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1441588



--- Comment #2 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
> Summary:	Build package from copr dist-git

Should be probably "Copr".


Can you mark LICENSE as %license in %files section? I.e.:

%license LICENSE

You should add:

Requires(pre): mock

otherwise it is possible that mock group does not exist yet when
%_sharedstatedir/copr-builder is being copied.


Hmm having 7 sources is little bit akward to me. But definitelly allowed by
guidelines so not a blocker. Just not so usual.

copr-builder has as shebang:
#! /bin/bash
The leading space... hmm it actually works! Never seen that.

You are using /var/lib/copr-builder/{pid,results,live-log}. You should own that
directories.
And lock file as %ghost.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux