Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ustr - String library, very low memory overhead, simple to import https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248231 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-07-27 14:31 EST ------- (In reply to comment #9) > * For /sbin/ldconfig, usually we don't write Requires(post) and > so on. > > Why? What is best practice, no deps. or just a normal requires? - The most unkind answer is that "it is as written on packaging guideline". http://fedoraproject.org/wiki/Packaging/ScriptletSnippets I guess /sbin/ldconfig is so common? Note: while I don't know if rpm adds the dependency for Requires(post) or etc, at least if %post -p <program> is written, rpm seems to add automatically the <program> to Requires. > * rpm (sub)packages which contains pkgconfig .pc files should > have "Requires: pkgconfig" > Obviously I can add it to the rpm anyway, if you want though. - Well, though I wrote "should", this is a "MUST" item of the review http://fedoraproject.org/wiki/Packaging/ReviewGuidelines (As written, the reason is directory ownership and usability for .pc file) > * mock build log says that fedora specific compilation flags are > not honored. > > Ok, I thought: > CFLAGS="${CFLAGS:-%optflags}" ; export CFLAGS ; > ...was enough, as that's what the %configure macro seems to be using. > I can't find any documentation on what I should be calling here > (there is no ./configure). %optflags is autually the flags we want to use. It is just CFLAGS you set is not honored by this way for this package (i.e. If normal way is not used to honor %optflags, you have to make %optflags honored *somehow*. Perhaps you have to investigate Makefile how compilation flags are used.) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review