https://bugzilla.redhat.com/show_bug.cgi?id=1441831 --- Comment #6 from mgansser@xxxxxxxx <mgansser@xxxxxxxxx> --- (In reply to Vít Ondruch from comment #5) > First of all, I am not Python packager, so not sure I catch everything ... > > * Dependencies > - Why there all the dependencies listed? I tried to remove all of them > except > of "python3-devel" and the build passed just fine. > - Actually, trying to prepare some module via nuvolasdk, it seems that you > should add: > > Requires: %{bindir}/scour > Requires: %{bindir}/gm done > > You have the runtime dependency on "lasem" there, but that is actually > just > library, you would need "lasem-render" executable or in case of Fedora > "lasem-render-0.4". But since it has huge dependency chain, I'd suggest > to > go with GraphicsMagic instead, which has the smallest footprint of all > the > supported graphics engines. > - Also, I am thinking if that might be just soft dependencies? Because > in case you'd like to use "lasem" instead of "gm", why to force somebody. > OTOH, if some Nuvola app is going to have build dependency on nuvolasdk, > there should be probably hard dependency. I probably thinking too much ;) > i used now GraphicsMagic > * Python macros > - Shouldn't you use %py3_build and %py3_install macros instead of the > "python > setup.py" calls? used mentioned macros > > * License > - It should be only BSD, shouldn't it? > ok, changed to BSD > * nuvolasdk/data/template/LICENSE-BSD.txt > - This file should not be marked as %licesne IMO. This file is just part > of a template for new project, not a real license file. unmarked nuvolasdk/data/template/LICENSE-BSD.txt as license file. NEW rpm files: Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvolasdk.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvolasdk-1.3.0-2.fc25.src.rpm %changelog * Thu Apr 13 2017 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 1.3.0-2 - Changed license field to BSD only - Add RR %%{_bindir}/scour - Add RR %%{_bindir}/gm - Use %%py3_build and %%py3_install macros instead of the "python setup.py" calls - Unmark %%license LICENSE nuvolasdk/data/template/LICENSE-BSD.txt - Remove BR ImageMagick-devel, librsvg2-devel, librsvg2-tools - Remove BR python3-scour, vala-devel, lasem -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
