https://bugzilla.redhat.com/show_bug.cgi?id=1441816 --- Comment #14 from mgansser@xxxxxxxx <mgansser@xxxxxxxxx> --- (In reply to Vít Ondruch from comment #13) > (In reply to mgansser@xxxxxxxx from comment #12) > > (In reply to Vít Ondruch from comment #11) > > > (In reply to mgansser@xxxxxxxx from comment #10) > > > > - Add BR python3-pyparsing > > > > > > Testing on Rawhide, this is not needed. > > > > should i use a if clause or what you mean ? > > If you are going to push Nuvola/Diorite into older Fedoras, then this is > probably good idea. At least you will know in the future that the dependency > can be dropped > > > %if 0%{?fedora} <= 26 > > BuildRequires: python3-pyparsing > > %endif > > > > ... > > You don't need the snipped bellow, do you? The test suite should always > pass, it just needs the dependency on older Fedoras. > > > %if 0%{?fedora} <= 26 > > %check > > LD_LIBRARY_PATH=./build ./build/run-dioritetests-%{major_version} > > %endif done if i request diorite as new package on https://admin.fedoraproject.org/pkgdb/request/package/ i get the message: There is already a package named: rpms/diorite -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
