https://bugzilla.redhat.com/show_bug.cgi?id=1441816 --- Comment #12 from mgansser@xxxxxxxx <mgansser@xxxxxxxxx> --- (In reply to Vít Ondruch from comment #11) > (In reply to mgansser@xxxxxxxx from comment #10) > > - Add BR python3-pyparsing > > Testing on Rawhide, this is not needed. should i use a if clause or what you mean ? %if 0%{?fedora} <= 26 BuildRequires: python3-pyparsing %endif ... %if 0%{?fedora} <= 26 %check LD_LIBRARY_PATH=./build ./build/run-dioritetests-%{major_version} %endif > > * There is one minor nit reported by rpmlint: > > diorite.x86_64: E: wrong-script-interpreter /usr/bin/diorite-testgen-0.3 > /usr/bin/env python3 corrected > > BTW I reported the issue with "waf install" to upstream: > > https://github.com/waf-project/waf/issues/1948 yes thanks, i saw the ticket already > > Otherwise the package looks good => APPROVED. @Vit many thanks for the review Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/diorite.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/diorite-0.3.3-3.fc25.src.rpm %changelog * Thu Apr 20 2017 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 0.3.3-3 - fixed wrong-script-end-of-line-encoding -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
