https://bugzilla.redhat.com/show_bug.cgi?id=1441816 --- Comment #9 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to mgansser@xxxxxxxx from comment #8) > (In reply to Vít Ondruch from comment #7) > > Thanks for updated package. > > > > * The stable release does not build on Rawhide :/ It seems the medicine is > > available here [1]. > > > [1] > > https://github.com/tiliado/diorite/commit/ > > 7e2683628d04e6f4f4a7cf4bc48a0af3937fbb1b > > should i generate a patch to allow build on Rawhide ? Yes, Rawhide is the first build target ... > > >> * There appears to be tests suite. Is there a chance to execute it during > > >> build? > > > > > > don't know what is the correct command ? > > > > It seems that "--with-experimental-api" configuration flag enables build of > > test suite. Later it can be executed by "LD_LIBRARY_PATH=./build > > ./build/run-dioritetests-0.3". But the experimental features requires > > "sqlite-devel" and I am not sure what is the impact on the installed > > libraries ... > > > > i changed this on the spec file to build the test-suite: > ... > %build > VALAFLAGS=--quiet waf configure --with-experimental-api \ > --prefix=%{_prefix} \ > --libdir=%{_libdir} > waf build --prefix=%{_prefix} \ > --libdir=%{_libdir} > > %install > waf install --no-ldconfig --prefix=%{_prefix} \ > --libdir=%{_libdir} \ > --destdir=%{buildroot} > > %check > LD_LIBRARY_PATH=./build ./build/run-dioritetests-0.3 > .... > > but the compilaton fails with: > > [ 62/114] Compiling build/main.c > [ 63/114] Compiling build/KeyValueStorage.c > [ 64/114] Compiling build/Dialogs.c > [ 65/114] Compiling build/run-dioritetests-0.3.c > In file included from ./dioritetests-0.3.h:8:0, > from run-dioritetests-0.3.c:9: > ./dioriteglib-0.3.h:14:38: fatal error: gio/gfiledescriptorbased.h: No such > file or directory > #include <gio/gfiledescriptorbased.h> > ^ > compilation terminated. > > glib-devel sqlite-devel and python3-pyparsingis is installed > > rpm -qf /usr/include/gio-unix-2.0/gio/gfiledescriptorbased.h > glib2-devel-2.50.3-1.fc25.x86_64 It seems that the author runs the tests either under windows or on his environment, so there is missing this bit: ~~~ --- wscript.orig 2017-04-18 17:10:41.940079460 +0200 +++ wscript 2017-04-18 15:46:27.868186780 +0200 @@ -304,8 +305,8 @@ ctx.program( target = RUN_DIORITE_TESTS, source = [ctx.path.find_or_declare("%s.vala" % RUN_DIORITE_TESTS)], - packages = "gio-2.0 glib-2.0", - uselib = "GIO GLIB", + packages = "gio-2.0 glib-2.0 gio-unix-2.0", + uselib = "GIO GLIB UNIXGIO", use = [DIORITE_GLIB, DIORITE_GTK, DIORITE_DB, DIORITE_TESTS], vala_defines = vala_defines, defines = ['G_LOG_DOMAIN="DioriteTests"'], ~~~ But this hunk is not upstreamable. There would need to be some Windows specific check, similar to [1]. [1] https://github.com/tiliado/diorite/blob/master/wscript#L227 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
