https://bugzilla.redhat.com/show_bug.cgi?id=1441816 --- Comment #7 from Vít Ondruch <vondruch@xxxxxxxxxx> --- Thanks for updated package. * The stable release does not build on Rawhide :/ It seems the medicine is available here [1]. * The installation should be run with "--no-ldconfig" option to prevent "/sbin/ldconfig: Can't create temporary cache file /etc/ld.so.cache~: Permission denied" error. >> * What is the reason to use the bundled version of "waf"? We have waf >> package in Fedora, is it possible to use it instead? > > I know this, but diorite need version 1.7.14 of waf, so i will use the bundle > version. Fedora have version 1.9.7 Well, there appears to be one minor silly issue. I sent PR fixing this upstream [2]. You can either apply my patch or go with "VALAFLAGS=--quiet" as simplest workaround. Here are the changes I tried: ~~~ $ diff -u diorite.spec{.orig,} --- diorite.spec.orig 2017-04-18 14:46:44.487155913 +0200 +++ diorite.spec 2017-04-18 14:48:35.329070349 +0200 @@ -15,6 +15,7 @@ BuildRequires: pkgconfig(python3) BuildRequires: pkgconfig(gtk+-3.0) BuildRequires: %{_bindir}/valac +BuildRequires: %{_bindir}/waf %description @@ -31,16 +32,19 @@ %prep %setup -qn %{name}-%{version} +rm ./waf +rm -rf ./.waf + cp -p %{SOURCE1} LICENSE %build -./waf configure --prefix=%{_prefix} \ +VALAFLAGS=--quiet waf configure --prefix=%{_prefix} \ --libdir=%{_libdir} -./waf build --prefix=%{_prefix} \ +waf build --prefix=%{_prefix} \ --libdir=%{_libdir} %install -./waf install --prefix=%{_prefix} \ +waf install --prefix=%{_prefix} \ --libdir=%{_libdir} \ --destdir=%{buildroot} ~~~ Unfortunately, the "waf install" triggers rebuild of some files and I was not lucky yet to find out what is the reason :/ >> * There is no license file included. Could you please query upstream to add >> one [3]? > > opened upstream ticket. > https://github.com/tiliado/diorite/issues/10 Thx. Unfortunately, you included wrong LICENSE file. The file you have included is GPL instead of BSD. Since the guidelines requires just to ask upstream but not include the file unless the file is provided in tarball, I'd suggest just to drop the file and wait until the LICENSE file is included in the upstream tarball. >> * There appears to be tests suite. Is there a chance to execute it during >> build? > > don't know what is the correct command ? It seems that "--with-experimental-api" configuration flag enables build of test suite. Later it can be executed by "LD_LIBRARY_PATH=./build ./build/run-dioritetests-0.3". But the experimental features requires "sqlite-devel" and I am not sure what is the impact on the installed libraries ... [1] https://github.com/tiliado/diorite/commit/7e2683628d04e6f4f4a7cf4bc48a0af3937fbb1b [2] https://github.com/tiliado/diorite/pull/11 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx