https://bugzilla.redhat.com/show_bug.cgi?id=1375986 --- Comment #11 from Fabio Valentini <decathorpe@xxxxxxxxx> --- There's only one major issue left as far as I can see: The Release: tag is "1", when it should be "1%{?dist}". No other changes are necessary for this. A cosmetic issue is that the conditional block between lines 141 and 147 is redundant, since the expression is always the same, so you could replace this: > %if ! 0%{?with_bundled} > export GOPATH=%{buildroot}/%{gopath}:%{gopath} > %else > # No dependency directories so far > > export GOPATH=%{buildroot}/%{gopath}:%{gopath} > %endif with just this: > export GOPATH=%{buildroot}/%{gopath}:%{gopath} Otherwise, the package looks good. If you fix the Release tag, I will approve the package. I will leave it up to you if you want to clean up the redundant conditional. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx