[Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1431763



--- Comment #2 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> ---
Hi Fabio,

I am taking this one.

- Conditional clauses on line 144 are duplicated.

- The guidelines for post releases have changed [1], in special, the release
tag for post release should not be in X.Y format (use just the X) and the date
the snapshot was taken must be included there.

- The test data could be included as a separate source file, but that's not a
blocker here.

[1] https://fedoraproject.org/wiki/Packaging:Versioning

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]