https://bugzilla.redhat.com/show_bug.cgi?id=1442547 --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- Going through fedora-review and analyzing the spec, I've noticed several issues: * fedora-review complains about gsignond being setuid. Is there a reason for this? If so, why? If anything, I don't see a good reason for it at all. If there *is* a good reason for it, it needs to be documented... * Your default-config subpackage doesn't make a ton of sense. First, why does it require the libs, when the libs don't care? It would probably make sense for the default-config subpackage to provide "%{name}-config" and have gsignond require it. * Your doc subpackage shouldn't require the libs, since it's development documentation. If you want it to require anything, it should require the devel subpackage, as it is developer documentation. * At the very least, the doc subpackage should be noarch, but as the config file doesn't appear to have any arch specific information, the default-config subpackage can also be noarch. * Some dependencies seem to have failed to be detected. Of note, it looked like it was looking for CHECK and LIBECRYPTFS, and those failed to be found. At least with those two, it looks like you don't have the appropriate pkgconfig() BuildRequires (pkgconfig(check) and pkgconfig(libecryptfs)). It was also unable to locate /usr/include/trousers/tss.h (provided by trousers-devel). * Since you're generating the autofoo, you need automake, autoconf, and autoconf-archive as BuildRequires. I'm not sure how the autogen.sh is working at the moment (maybe something else is pulling it in when it shouldn't), but in this case, it's better to be explicit about it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx