[Bug 1441813] Review Request: colorful - simple side-view shooter game

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1441813



--- Comment #2 from Iwicki Artur <iwicki.artur@xxxxxxxxxx> ---
Thank you for the thorough review.

1. I've added a patch which removes the need for the bundled library.

4. I've added an equal-version requirement.

6. I originally intended to group stuff needed by my software in
/usr/share/suve, which would then contain sub-directories for programs. If I
understand the wiki page correctly, multiple ownership shouldn't be a problem,
so I went ahead and added the directory to the %files list. Still, if single
ownership is the preferred solution, I can just make a patch that'll move the
files to simply /usr/share/colorful. 

Points 2, 3, 5 and 7 have also been fixed.

spec: https://svgames.pl/fedora/colorful-1.2-9.spec
srpm: https://svgames.pl/fedora/colorful-1.2-9.src.rpm

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=19008565
copr: https://copr.fedorainfracloud.org/coprs/suve/colorful/build/539942/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux