https://bugzilla.redhat.com/show_bug.cgi?id=1441813 Mikolaj Izdebski <mizdebsk@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mizdebsk@xxxxxxxxxx --- Comment #1 from Mikolaj Izdebski <mizdebsk@xxxxxxxxxx> --- 1. Licensing review: Some source files (bundled SDL_mixer.pas) seem to be licensed under MPL v1.1. License tag in spec file should reflect that. See: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License:_field 2. Missing BuildRequires: make, glibc-devel All build-time dependencies must be listed as BuildRequires, even basic ones like make and glibc-devel. For more info, see: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2 3. You shouldn't list explicit requires on shared libraries. RPM will generate these requires automatically. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires 4. Requires on data package should be versioned. Otherwise RPM will happily allow users to install different (possibly incompatible) versions of game binary and data. 5. Desktop file is installed incorrectly (/usr/share/applications/colorful.desktop/colorful.desktop) 6. File ownership: directory /usr/share/suve is not owned. See: https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership 7. It's nice to try to preserve timestamps when copying files (use cp -a instead of -R). See: https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx