[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1424890



--- Comment #20 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
(In reply to Per Bothner from comment #19)
> "The built domterm package contains the directory /usr/lib/.build-id/  --
> which looks to me like leftovers from the build. Probably this isn't needed
> in the binary RPM, right?"
That's generated by rpm itself. It was added in
https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo. rpmlint
doen't know about this yet.

> "The spec License tag simply says "BSD". Since there are so many variants on
> the BSD license, I don't think that's specific enough."
> 
> From what I can tell, "BSD" is correct:
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/
> LicensingGuidelines#Valid_License_Short_Names
> https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses
Yes.

> "Moreover, fedora-review's license check finds 3 files in /qtdomterm/ which
> have comments stating that they use the GNU GPL, which I think might mean
> that all of DomTerm should also use GPL(?)."
> 
> Only qtdomterm needs to be GPL.  This is only an issue with certain
> "backend" files, and I think it will make sense to rip those out in favor of
> using ldomterm, for the sake of simplicity.  But until then I changed the
> qtdomterm license to "GPLv2+".
> 
> "I also suspect that all these files containing copied code might amount to
> library bundling, which is at least discouraged in Fedora."
Bundling is allowed since 
https://pagure.io/fesco/issue/1483. Bundling is reluctantly accepted. This
makes a lot of sense especially for javascript. Most people have given up
on unbundling javascript.


The appdata file should be validated using appstream-util validate-relax
--nonet.
(If the make file does this already by itself, ignore my comment.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux